Fix SVN dirty calculation #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sodevel , first of all, many thanks for this contribution and I'm sorry for the delay (for any reason, I did not receive any notification any longer about this repository, which was very unfortunate, and I did not see your PR). Now, I have merged some previous PRs and your code is now in conflict with some other changes. Would you be so kind as porting your changes to the new code by solving these conflicts against the Thanks, |
The previous test for the dirty state was flawed and detected externals always as dirty. Use a test for the clean state instead and invert to receive the required value for the filter criteria.
It is unknown why this directory was excluded from the dirty calculation and the check for the empty relative path had the side effect that changes of the project root directory got ignored.
|
I rebased against the new base branch and fixed the conflicts. The code is looking good, however currently i can't access my usual environment and therefor can't build and test the plugin to verify. |
|
Just a small update, now i could build and test the plugin, it is working for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that my svn working copies always get marked as dirty although they have been clean. The issue is that the logic of the dirty calculation is broken and detects externals always as dirty. While fixing this, i also discovered that the dirty state of the root directory of the working copy was not detected. This is because the relative path calculation returns an empty path for the root directory which is always marked as clean.
I don't know why the entry
/userHomeor root should always be marked as clean so i simply removed this calculation and test.